Fix #14596 - fixed label logic #14597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
previous commit incorrectly assumed that value equaled option. This assumption was incorrect and broke the table's filter option dropdown
|
After I originally submitted this pull request, I manually tested the p-table's column filters which also uses p-dropdown. My original changes broke those dropdown. As a result, I updated my changes. The updated code (which is more complicated) now works on all the dropdown demos and the table demos. |
Closed
|
this pull request has been superseded by Pull Request #14665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14596
The following video demonstrates the fix.
DropdownFilterBugFix.mov
To fix this issue, I updated the logic for computing the dropdown's label.
Note: For "virtual scroll" configurations, the original logic is unchanged
I manually tested my fix on all the PrimeNG dropdown demos