Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14190: Dropdown: autoDisplayFirst not working #14413

Closed
wants to merge 2 commits into from

Conversation

kkoripl
Copy link

@kkoripl kkoripl commented Dec 20, 2023

Fix #14190
Fix #14318

The problem was that the value that was set in writeValue after being properly selected to modelValue was null.
The solution is taken from v16.7.0 version:
image

Before:
autofirstDisplay-without-fix

After:
autofirstDisplay-fix

<Note: for demonstration, I've removed placeholder from the dropdown. The white flash you see there is a page refresh>

One thing though, with your latest change to switch default value of autoDisplayFirst to true, now each and every presentation at demo page will have value selected at startup. Placeholder will be seen, when we'll remove it, i.e. at 'Basic' example.

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2024 8:42am

@kkoripl kkoripl changed the title Fix #14190 + Fix #14318: Dropdown: autoDisplayFirst=true not working Fix #14190: Dropdown: autoDisplayFirst=true not working Dec 20, 2023
@kkoripl kkoripl changed the title Fix #14190: Dropdown: autoDisplayFirst=true not working Fix #14190: Dropdown: autoDisplayFirst not working Dec 20, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

This feature will be removed in the v18. Thanks a lot for the effort and support, closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: autoDisplayFirst=true not working Dropdown Component
2 participants