SplitButton | Flag for hiding menu on default button click. #14395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Hi, This feature is not necessary, splitbutton should only open the menu when clicking the menu trigger button. Otherwise, it would be the same as popup menu and splitbutton would be unnecessary. This behavior also can be done by utilizing popup feature of the menu component. Thanks a lot for the effort and support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue on fix #13962 from #13983.
So right now, when someone would like to have same behaviour on default button as it was for the menu button, it was impossible due to hiding menu after event handling.
One can see that here: https://stackblitz.com/edit/8tkckf?file=src%2Fapp%2Fdemo%2Fsplit-button-basic-demo.html
After the change, with setting the new flag to true, the same behaviour on default and menu button will be possible.
Probably there can be a flag to have same behaviour for both buttons, but... with onClick still possible to be set, both setups would be against each other.
BEFORE:
AFTER:
