Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(AutoComplete): Change Detection Issue #14268

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fix(AutoComplete): Change Detection Issue #14268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ded6445
Add detectChanges() onInit
SoyDiego Dec 3, 2023
960482b
Formatted code
SoyDiego Dec 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/app/components/autocomplete/autocomplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,7 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr

ngOnInit() {
this.id = this.id || UniqueComponentId();
this.cd.detectChanges();
}

ngAfterViewChecked() {
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/image/image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ export class Image implements AfterContentInit {
imagePreviewStyle() {
return { transform: 'rotate(' + this.rotate + 'deg) scale(' + this.scale + ')' };
}

get zoomImageAriaLabel() {
return this.config.translation.aria ? this.config.translation.aria.zoomImage : undefined;
}
Expand Down
4 changes: 1 addition & 3 deletions src/app/components/toast/toast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export class ToastItem implements AfterViewInit, OnDestroy {

timeout: any;

constructor(private zone: NgZone,private config: PrimeNGConfig) {}
constructor(private zone: NgZone, private config: PrimeNGConfig) {}

ngAfterViewInit() {
this.initTimeout();
Expand Down Expand Up @@ -192,8 +192,6 @@ export class ToastItem implements AfterViewInit, OnDestroy {
ngOnDestroy() {
this.clearTimeout();
}


}

/**
Expand Down
4 changes: 1 addition & 3 deletions src/app/showcase/doc/Image/accessibilitydoc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ import { Component } from '@angular/core';
selector: 'accessibility-doc',
template: ` <app-docsectiontext>
<h3>Screen Reader</h3>
<p>
The preview button is a native <i>button</i> element with an <i>aria-label</i> that refers to the <i>aria.zoomImage</i> property of the <a href="/configuration/#locale">locale</a> API by default.
</p>
<p>The preview button is a native <i>button</i> element with an <i>aria-label</i> that refers to the <i>aria.zoomImage</i> property of the <a href="/configuration/#locale">locale</a> API by default.</p>
<p>When preview is active, <i>dialog</i> role with <i>aria-modal</i> is applied to the overlay image container.</p>
<p>Button controls use <i>aria.rotateRight</i>, <i>aria.rotateLeft</i>, <i>aria.zoomIn</i>, <i>aria.zoomOut</i> and <i>aria.close</i> from the <a href="/configuration/#locale">locale</a> API as <i>aria-label</i>.</p>
<h3>ButtonBar Keyboard Support</h3>
Expand Down
Loading