Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13709 ColorPicker: Setting Hex / RGB / HSB code in component #14090

Conversation

ondriiicek
Copy link

@ondriiicek ondriiicek commented Nov 11, 2023

In this PR, the colorpicker component was modified. Select was added so that the user can choose which color model he wants to use. Inputs have been added for each color model (RGB, HEX, HSB) where the user can enter the color code directly in the component. Two buttons were also added for confirming the color change and resetting to the default color.

Issue: #13709

Copy link

vercel bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 8:30am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2023 8:30am

@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test November 11, 2023 17:17 Inactive
@SoyDiego
Copy link
Contributor

Hi, can you provide a description, screenshot, issue or something to understand your PR?
Thanks :)

@ondriiicek
Copy link
Author

Hi, it is for school purposes, in one of our university course we should find github issue, solve it and create PR.
In primeng project i found this issue: #13709 and solve it by creating something like this:

image

@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test November 12, 2023 08:30 Inactive
@ondriiicek ondriiicek marked this pull request as ready for review November 12, 2023 08:39
@ondriiicek ondriiicek changed the title #13709 new colorpicker input field #13709 ColorPicker: Setting Hex / RGB / HSB code in component Nov 12, 2023
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Mar 12, 2024
Copy link

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you for your understanding!

@github-actions github-actions bot closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants