Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce allowEmpty for SelectButton, fixes issue #14048 #14049

Merged

Conversation

rosenthalj
Copy link
Contributor

@rosenthalj rosenthalj commented Nov 7, 2023

Fixes #14048

Added a check to see if allowEmpty equals false before updating selected to null

check allowEmpty test before setting selected
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 10:07am

@SoyDiego
Copy link
Contributor

SoyDiego commented Nov 7, 2023

Fixes Issue #14048

Added a check to see if allowEmpty equals false before updating selected to null

Looks good, add "Fixes #14848" to your first message to link this PR to the issue and when PrimeNG team approve it, will be close automatically. Thanks for your contribution

@cetincakiroglu cetincakiroglu merged commit afa0608 into primefaces:master Nov 8, 2023
1 of 3 checks passed
@rosenthalj rosenthalj deleted the SelectButtonPartiallyFixed branch November 9, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectButton in v16.7.1 is only partially fixed
3 participants