Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed dropdown navigation (issue #13903) #13904

Closed
wants to merge 1 commit into from

Conversation

rosenthalj
Copy link
Contributor

Fixes issue #13903

  1. Implement "special" processing for escape and tab only if the overlay is visible
  2. Updated documentation

The following video shows the fix working. After the fix, a user can navigate away from a dropdown

dropdownKeyboardNavigationFix.mov

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 4:00pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 4:00pm

@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test October 17, 2023 16:00 Inactive
@cetincakiroglu
Copy link
Contributor

Hi @rosenthalj

Thanks a lot for the contribution but we cannot accept this PR since we're currently implementing accessibility across PrimeNG and we just completed the dropdown last week. We're planning to release the input section next week Wednesday.

Closing the PR, thanks a lot for the effort and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants