Issue #13816 | MultiSelect - Delete button is not visible on chips with long label text #13825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
cetincakiroglu
changed the title
SoyDiego
reviewed
Oct 8, 2023
| @@ -188,5 +188,8 @@ | |||
| } | |||
| } | |||
| } | |||
| }, | |||
| "cli": { | |||
| "analytics": false | |||
There was a problem hiding this comment.
This code is not necessary
SoyDiego
reviewed
Oct 8, 2023
| @@ -10,7 +10,7 @@ import { NodeService } from '../../service/nodeservice'; | |||
| <p>In single selection mode, value binding should be the <i>key</i> value of a node.</p> | |||
| </app-docsectiontext> | |||
| <div class="card flex justify-content-center"> | |||
| <p-treeSelect class="md:w-20rem w-full" containerStyleClass="w-full" [(ngModel)]="selectedNodes" [options]="nodes" placeholder="Select Item"></p-treeSelect> | |||
| <p-treeSelect class="md:w-20rem w-full" [showClear]="true" containerStyleClass="w-full" [(ngModel)]="selectedNodes" [options]="nodes" placeholder="Select Item"></p-treeSelect> | |||
There was a problem hiding this comment.
why you added the property [showClear] in treeSelect. I think is not necessary add that
SoyDiego
reviewed
Oct 8, 2023
src/app/components/panel/panel.ts
Outdated
| @@ -50,6 +50,7 @@ import { PanelAfterToggleEvent, PanelBeforeToggleEvent } from './panel.interface | |||
|
|
|||
| <ng-template *ngTemplateOutlet="headerIconTemplate; context: { $implicit: collapsed }"></ng-template> | |||
| </button> | |||
| <button (click)="toggle($event)">collapse</button> | |||
There was a problem hiding this comment.
I don't understand your PR abour multiselect component but you are modifying another components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing css.