Fixed OverlayPanel containing component #13809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes case when a component is present inside the OverlayPanel. After a low number of clicks inside the OverlayPanel it hid randomically.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Hi, Thanks a lot for the effort and support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13601
Fixes #13605
Problem
Starting from version 16.2.0 the component OverlayPanel suffered a significant regression when it contains a component through the template directive.
It would close after a random number of clicks inside the contained component, making the component unusable. The problem is reproducible by inserting any PrimeNg component inside the OverlayPanel and rendering it through Template directive.
Solved
Restored part of the check previously modified in PR #13480 to solve problem where OverlayPanel component would not close when user clicks outside the panel.