fix: #13781 || dataTable: frozenColumn header overlap with frozen body #13791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@SoyDiego I will be happy if you check this PR. |
|
@gucal hi, can you please check this PR. Thanks in advance. Please feel free give me any feedback . |
|
Solution worked for me thanks |
Yea seems like the z index on the tables are abit finicky but changing the values of it seemed to work. Hopefully the PR can get tested and approved |
|
@gucal hi, can you please check this PR. Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix: #13781
Explanation
I apologize for any oversight in my previous pull request. In this new pull request, I've taken steps to ensure that the changes won't adversely affect any other parts of the codebase.
The primary change in this PR involves adjusting the z-index values for various elements. Specifically, I've set the z-index of datatable-thead and rowgroup-header to level 2, and the datatable-loading-overlay now has a z-index of 3.
I also considered raising the z-index of datatable-tfoot to level 2, but after thorough testing, I couldn't identify any issues with the current setup. I'm somewhat uncertain about whether this adjustment is necessary, so I'd appreciate any guidance or suggestions in this regard.
Please review the changes, and I'm open to any feedback or additional adjustments to ensure the code remains robust. Thank you for your time and consideration.