Editor: Fix background-color in dark mode themes #13787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
SoyDiego
changed the title
# Conflicts: # src/assets/components/themes/arya-blue/theme.css # src/assets/components/themes/arya-green/theme.css # src/assets/components/themes/arya-orange/theme.css # src/assets/components/themes/arya-purple/theme.css # src/assets/components/themes/bootstrap4-dark-blue/theme.css # src/assets/components/themes/bootstrap4-dark-purple/theme.css # src/assets/components/themes/bootstrap4-light-blue/theme.css # src/assets/components/themes/bootstrap4-light-purple/theme.css # src/assets/components/themes/fluent-light/theme.css # src/assets/components/themes/lara-dark-blue/theme.css # src/assets/components/themes/lara-dark-indigo/theme.css # src/assets/components/themes/lara-dark-purple/theme.css # src/assets/components/themes/lara-dark-teal/theme.css # src/assets/components/themes/lara-light-blue/theme.css # src/assets/components/themes/lara-light-indigo/theme.css # src/assets/components/themes/lara-light-purple/theme.css # src/assets/components/themes/lara-light-teal/theme.css # src/assets/components/themes/luna-amber/theme.css # src/assets/components/themes/luna-blue/theme.css # src/assets/components/themes/luna-green/theme.css # src/assets/components/themes/luna-pink/theme.css # src/assets/components/themes/md-dark-deeppurple/theme.css # src/assets/components/themes/md-dark-indigo/theme.css # src/assets/components/themes/md-light-deeppurple/theme.css # src/assets/components/themes/md-light-indigo/theme.css # src/assets/components/themes/mdc-dark-deeppurple/theme.css # src/assets/components/themes/mdc-dark-indigo/theme.css # src/assets/components/themes/mdc-light-deeppurple/theme.css # src/assets/components/themes/mdc-light-indigo/theme.css # src/assets/components/themes/mira/theme.css # src/assets/components/themes/nano/theme.css # src/assets/components/themes/nova-accent/theme.css # src/assets/components/themes/nova-alt/theme.css # src/assets/components/themes/nova/theme.css # src/assets/components/themes/rhea/theme.css # src/assets/components/themes/saga-blue/theme.css # src/assets/components/themes/saga-green/theme.css # src/assets/components/themes/saga-orange/theme.css # src/assets/components/themes/saga-purple/theme.css # src/assets/components/themes/soho-dark/theme.css # src/assets/components/themes/soho-light/theme.css # src/assets/components/themes/tailwind-light/theme.css # src/assets/components/themes/vela-blue/theme.css # src/assets/components/themes/vela-green/theme.css # src/assets/components/themes/vela-orange/theme.css # src/assets/components/themes/vela-purple/theme.css # src/assets/components/themes/viva-dark/theme.css # src/assets/components/themes/viva-light/theme.css
# Conflicts: # src/assets/components/themes/arya-blue/theme.css # src/assets/components/themes/arya-green/theme.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13786
The solution of this issue, you can find in
primeng-sass-themeproject primefaces/primeng-sass-theme#55. Here I only compiled all the scss of the project in all the themes and the only line that was changed for the compilation in all the files is:.p-editor-container .p-editor-toolbar.ql-snow .ql-picker.ql-expanded .ql-picker-optionsadding only!importantinbackground-colorproperty.I added the
!importantbecause the styles were being taken by Quill Editor and I cannot remove the line of that file because is imported fromnode_modulesin PrimeNG project:If something is not OK or exists a better way, let me know and I can change it :)
CURRENTLY
AFTER SOLUTION