fix(#13481): add id back to menu item content

[dalenguyen]

Defect Fixes

Fix #13481

this.items = [
    {
        label: 'New',
        icon: 'pi pi-fw pi-plus'
    },
    {
        id: 'delete',
        label: 'Delete',
        icon: 'pi pi-fw pi-trash'
    }
];

The id="delete" is added correctly to the menu item content.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Sep 23, 2023 3:20pm

[SaajRP]

PrimeNg team has yet to mention if setting the id to the anchor tag was removed intentionally or if it was done accidentally

Just to note the p-tabMenu, which also uses MenuItem, passes the id to getItemProp function instead of directly assigning the id to the anchor tag
[attr.id]="getItemProp(item, 'id')"

https://github.com/primefaces/primeng/blob/master/src/app/components/tabmenu/tabmenu.ts

[dalenguyen]

@SaajRP I can see that the Id is still in the model, allowing us to assign an id to the item. I checked the getItemProp function, it behaves the same way since it will get the property from the object or return undefined.

On a side note, just wonder why the team has to put all functions to the ObjectUtils which will import all functions under it. Wonder if it's treeshakable or not 🤔

[cetincakiroglu]

Hi,

This issue is a duplicate of #13705 and it's fixed in here 44a5075

Closing the issue since it's duplicate and already fixed.

Thanks a lot for your effort and support!