Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog | Add missing templates (message, icon) & update the docs #13703

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

cetincakiroglu
Copy link
Contributor

@cetincakiroglu cetincakiroglu commented Sep 19, 2023

Fixes #13700

message and icon templates added.

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2023 1:09pm

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Sep 19, 2023
@cetincakiroglu cetincakiroglu changed the title ConfirmDialog | Add missing templates (message, icon) & update the docs Fixed #13700 ConfirmDialog | Add missing templates (message, icon) & update the docs Sep 19, 2023
@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@cetincakiroglu cetincakiroglu changed the title Fixed #13700 ConfirmDialog | Add missing templates (message, icon) & update the docs ConfirmDialog | Add missing templates (message, icon) & update the docs Sep 19, 2023
@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

@cetincakiroglu cetincakiroglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Sep 21, 2023
@cetincakiroglu cetincakiroglu merged commit d3ab722 into master Sep 21, 2023
1 of 5 checks passed
@cetincakiroglu cetincakiroglu deleted the issue-13700 branch September 21, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfirmDialog: pTemplate="message" and pTemplate="icon" is missing
2 participants