Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialog: Possible fix ExpressionChangedAfterItHasBeenCheckedError with attr.aria-labelledby #13644

Merged
merged 4 commits into from
Sep 30, 2023
Merged

dialog: Possible fix ExpressionChangedAfterItHasBeenCheckedError with attr.aria-labelledby #13644

merged 4 commits into from
Sep 30, 2023

Conversation

SoyDiego
Copy link
Contributor

@SoyDiego SoyDiego commented Sep 9, 2023 •
edited
Loading

Possible Fix #13636.

I added the same logic used in #13538.

I couldn't replicate the problem in this case. Only @psarno, did it. But we can try with the same solution.

Note: I only changed the dialog.ts, the rest of files were formatted.

@vercel
Copy link

vercel bot commented Sep 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2023 7:26am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2023 7:26am

@SoyDiego SoyDiego changed the title Possible fix dialog error dialog: Possible fix ExpressionChangedAfterItHasBeenCheckedError with attr.aria-labelledby Sep 9, 2023
@SoyDiego SoyDiego mentioned this pull request Sep 9, 2023
Closed
@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test September 9, 2023 14:18 Inactive
@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test September 24, 2023 15:56 Inactive
@ashikjs
Copy link
Contributor

ashikjs commented Sep 25, 2023

@SoyDiego can you squash those three commit to a single commit so we can ensure it, one single commit for a solution.

@SoyDiego
Copy link
Contributor Author

@SoyDiego can you squash those three commit to a single commit so we can ensure it, one single commit for a solution.

Hi, thanks for check.
Like I said in the note, I only changed the dialog.ts, the rest of files were formatted.

Regards

@cetincakiroglu cetincakiroglu added Status: Pending Review Issue or pull request is being reviewed by Core Team Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Sep 25, 2023
@jncalderon
Copy link

Hi!! some update? to be honest I really need it :(

@cetincakiroglu cetincakiroglu merged commit 4dda67c into primefaces:master Sep 30, 2023
2 checks passed
@cetincakiroglu cetincakiroglu removed Status: Pending Review Issue or pull request is being reviewed by Core Team Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Sep 30, 2023
@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test September 30, 2023 07:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volvachev volvachev volvachev left review comments

@ashikjs ashikjs ashikjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

p-dialog: ExpressionChangedAfterItHasBeenCheckedError with attr.aria-labelledby
5 participants
@SoyDiego @ashikjs @jncalderon @volvachev @cetincakiroglu