Fix: Es Linter Issue #13642
Merged
Fix: Es Linter Issue #13642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might have to add seperate es lint config file for showcase as the prefixes are app- in this folder
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
SoyDiego
approved these changes
Sep 9, 2023
|
Please add to your first post: Fix #13641 to link your PR to the opened issue. Thanks! |
cetincakiroglu
added
the
Type: Bug
cetincakiroglu
removed
the
Type: Bug
Closed
|
Hi, I'm reverting this PR because it throws an error due to the custom casing of prime components. You can open a new issue and fix it again properly |
cetincakiroglu
added a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fixes #13641
ESLint was not working because of few miss configurations, and it is fixed with this PR
PS: I see a lot of unused code and unused imports on code after this fix. Please consider merging this PR so that maintaining code will be easier. Also, we might have to consider a separate ESLint config for showcase folder as the prefix for those components are different from the actual library (app- vs p-)
BEFORE FIX
AFTER FIX
