Fixed curser position for negative numbers with suffix #13640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a negative number is entered with a suffix and minimum fraction digits, the format was incorrect. For example: -suffix " %" -minFractionDigits 2 -0 resulted in a -00 concat value. (correct would be 0.00 %) This results in a new call of formatValue() in handleOnInput(). The format is then correct, but the cursorposition is put to the end of the input: "0.00 %|" instead of "0|.00 %"
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Thanks for your contribution. |
|
Added issue |
Fix #13651 with # symbol to link your issue to this PR |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
bot
added
the
Resolution: Stale
|
Anything i can do to speed this up? |
cetincakiroglu
removed
the
Resolution: Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a negative number is entered with a suffix and minimum fraction digits, the format was incorrect.
For example:
-suffix " %"
-minFractionDigits 2
-0 resulted in a -00 concat value. (correct would be 0.00 %)
This results in a new call of formatValue() in handleOnInput(). The format is then correct, but the cursorposition is put to the end of the input: "0.00 %|" instead of "0|.00 %"
Fix #13651