Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #13390 #13608

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Fix for issue #13390 #13608

merged 6 commits into from
Sep 26, 2023

Conversation

rosenthalj
Copy link
Contributor

@rosenthalj rosenthalj commented Sep 3, 2023

Fix #13390

Listed below are 6 movies:

The first 3 movies show the original functionality before any changes

  • Movie 1 the original issue
  • Movies 2 and 3 the original functionality when navigating the menubar using the right and left arrow keys

The second 3 movies show the new functionality after the changes

  • Movie 4 the issue fixed
  • Movies 5 and 6 the new functionality when navigating the menubar using the right and left arrow keys

Note: The navigation after the fix is different than before the fixe. I personally think its better

1_beforeChangesOriginalProblem.mov
2_beforeChangesWithRightAndLeftMouseButtonLargerWidth.mov
3_beforeChangesWithRightAndLeftMouseButtonSmallerWidth.mov
4_afterChangesOriginalProblem.mov
5_afterChangesWithRightAndLeftMouseButtonLargerWidth.mov
6_afterChangesWithRightAndLeftMouseButtonSmallerWidth.mov

@vercel
Copy link

vercel bot commented Sep 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 9:50am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 9:50am

@rosenthalj rosenthalj changed the title changed inline: 'start' to inline: 'nearest' fixes for issue #13390 Sep 3, 2023
@rosenthalj rosenthalj changed the title fixes for issue #13390 Fix for issue #13390 Sep 3, 2023
@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test September 3, 2023 12:21 Inactive
Note:  changes fixed formatting errors that were prexisting before my changes
@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test September 3, 2023 12:33 Inactive
@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test September 3, 2023 12:41 Inactive
@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test September 3, 2023 12:54 Inactive
@SoyDiego
Copy link
Contributor

SoyDiego commented Sep 7, 2023

Add in your first comment the text Fix #13390 and will link your PR with the issue and if PrimeNG Team approve it, will close automatically the issue.

@cetincakiroglu cetincakiroglu merged commit b1c6e60 into primefaces:master Sep 26, 2023
1 check failed
@cetincakiroglu
Copy link
Contributor

Hi @rosenthalj

Thanks a lot for the contribution, we appreciate your effort and support!

@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test September 26, 2023 09:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrimeNG 16.1.0 selecting a menu option causes panel to scroll
3 participants