Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(primeng/p-tabview): show the `forward' button when necessary #12913

Closed
wants to merge 1 commit into from
Closed

fix(primeng/p-tabview): show the `forward' button when necessary #12913

wants to merge 1 commit into from

Conversation

volvachev
Copy link
Contributor

reopen with fixes

Defect Fixes

Fixes #11684

@vercel
Copy link

vercel bot commented Apr 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2023 2:24pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2023 2:24pm

@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test April 20, 2023 05:22 Inactive
@volvachev volvachev force-pushed the fix-tabview-forward-btn branch from 7a1ee23 to 8e4c3aa Compare May 23, 2023 18:57
@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test May 23, 2023 19:22 Inactive
@TS-Tino16 TS-Tino16 mentioned this pull request Jul 11, 2023
Open
@mertsincan mertsincan added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Aug 21, 2023
@mertsincan mertsincan added this to the 16.Future milestone Aug 21, 2023
@mertsincan
Copy link
Member

Hi @volvachev,

Thanks a lot for your contribution! But, this PR is outdated! Could you please update it? Then, I'll review it asap.

Best Regards,

@mertsincan mertsincan added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Aug 21, 2023
@volvachev volvachev force-pushed the fix-tabview-forward-btn branch from 8e4c3aa to b709ac3 Compare September 23, 2023 14:18
@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test September 23, 2023 14:24 Inactive
@volvachev
Copy link
Contributor Author

Hi @volvachev,

Thanks a lot for your contribution! But, this PR is outdated! Could you please update it? Then, I'll review it asap.

Best Regards,

Hi, I've updated mr

@cetincakiroglu
Copy link
Contributor

Hi @volvachev,

We've implemented an enhancement which solves the issue. I'm closing this one. Thanks a lot for the effort and support!

@cetincakiroglu cetincakiroglu removed Status: Discussion Issue or pull request needs to be discussed by Core Team Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Mar 22, 2024
@cetincakiroglu cetincakiroglu removed this from the 17.Future milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TabView: Next-button occurs also if nothing is to scroll
3 participants
@volvachev @mertsincan @cetincakiroglu