Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar enhancements to restrict year, month and date navigation beyond minDate and maxDate. #12870

Conversation

subhajitdebnath
Copy link

Defect Fixes

Fixes issues #12583, #12151, #11029

  1. This restricts year, month and date navigation beyond minDate and maxDate.
  2. Also restricts navigation by disabling the previous and next buttons in each of the three views beyond minDate and maxDate.

Need your support as this is my first PR. Thanks.

@vercel
Copy link

vercel bot commented Apr 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Apr 8, 2023 10:41am

@subhajitdebnath subhajitdebnath changed the title Datepicker enhancements Calendar enhancements to restrict year, month and date navigation beyond minDate and maxDate. Apr 8, 2023
@cetincakiroglu cetincakiroglu self-requested a review April 25, 2023 06:48
@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Apr 25, 2023
@mertsincan
Copy link
Member

Hi @subhajitdebnath,

Sorry for the delayed response! Unfortunately, it is out of date. Could you please try your case with #12154? If the problem persists, please update your PR and then I'll check it asap.

Thanks a lot for your contribution!
Best Regards,

@mertsincan mertsincan added Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Aug 18, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 18, 2023
@mertsincan mertsincan removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Aug 29, 2023
@mertsincan mertsincan removed this from the 16.2.1 milestone Aug 29, 2023
@mertsincan mertsincan added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Aug 29, 2023
@mertsincan
Copy link
Member

Hi,

This PR is outdated and there doesn't seem to be any interaction on it. So, closed. Could you please create a new PR for us? Thanks a lot for your understanding and contribution!

Best Regards,

@mertsincan mertsincan closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants