feat(primeng/p-badge): rework dynamic property rerender for directive #12739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
volvachev
force-pushed
the
feat-rework-badge-directive
branch
2 times, most recently
from
0356fca to
0abff48
Compare
|
Hi, @cetincakiroglu can you look? |
volvachev
force-pushed
the
feat-rework-badge-directive
branch
from
0abff48 to
71bc3af
Compare
volvachev
force-pushed
the
feat-rework-badge-directive
branch
from
71bc3af to
a1311b0
Compare
volvachev
force-pushed
the
feat-rework-badge-directive
branch
from
a1311b0 to
96d42ce
Compare
|
@cetincakiroglu anything we can do to get this merged? |
mertsincan
added
Type: Breaking Change
cetincakiroglu
added
the
Status: Pending Review
|
Hi @volvachev, Could you please resolve the conflicts and instead of removing the size property from badge which leads to breaking change, could you please deprecate it and add the new property? I'll merge it after these changes. |
volvachev
force-pushed
the
feat-rework-badge-directive
branch
from
96d42ce to
7b19c33
Compare
Hi, I've updated |
cetincakiroglu
removed
Status: Pending Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fixes #12736
Fixes #12959