Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: aria-describedBy not applied to target #16630

Closed
dermartinschmitz opened this issue Oct 24, 2024 · 0 comments · Fixed by #16889
Closed

Tooltip: aria-describedBy not applied to target #16630

dermartinschmitz opened this issue Oct 24, 2024 · 0 comments · Fixed by #16889
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.18.13

Comments

@dermartinschmitz
Copy link
Contributor

Describe the bug

The tooltip documentation states that the tooltip's id should be used for the aria-describedby attribute of the target element. While the role and id are correctly assigned to the tooltip itself, the aria-describedby attribute is not automatically applied to the target element as expected.

Environment

PrimeNG Version 17.18.11

Reproducer

No response

Angular version

18.2.0

PrimeNG version

17.18.11

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@dermartinschmitz dermartinschmitz added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 24, 2024
@dermartinschmitz dermartinschmitz changed the title Tooltip: describedBy not applied to target Tooltip: aria-describedBy not applied to target Oct 24, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Nov 19, 2024
dermartinschmitz pushed a commit to dermartinschmitz/primeng that referenced this issue Nov 29, 2024
fix(primefaces#16630): ensure aria-describedby is dynamically set and…
33cff6f 
… removed for tooltip

This fix improves accessibility by maintaining proper ARIA relationships for tooltips.

- Added `setAriaDescribedBy` to dynamically set `aria-describedby` attribute on the target element when the tooltip is created.
- Added `removeAriaDescribedBy` to remove the `aria-describedby` attribute when the tooltip is removed.
@dermartinschmitz dermartinschmitz mentioned this issue Nov 29, 2024
Merged
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 6, 2024
mertsincan pushed a commit that referenced this issue Dec 6, 2024
@dermartinschmitz
fix(#16630): ensure aria-describedby is dynamically set and removed f…
f03542f 
…or tooltip (#16889)

This fix improves accessibility by maintaining proper ARIA relationships for tooltips.

- Added `setAriaDescribedBy` to dynamically set `aria-describedby` attribute on the target element when the tooltip is created.
- Added `removeAriaDescribedBy` to remove the `aria-describedby` attribute when the tooltip is removed.

Co-authored-by: Martin Schmitz <[email protected]>
@github-project-automation github-project-automation bot moved this to Done in PrimeNG Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
PrimeNG
Status: Done
Milestone
17.18.13
2 participants
@mertsincan @dermartinschmitz