Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicDialog: accessibility- CloseAriaLabel not working #15144

Closed
mcarrilesgozalvez opened this issue Mar 22, 2024 · 0 comments · Fixed by #15152
Closed

DynamicDialog: accessibility- CloseAriaLabel not working #15144

mcarrilesgozalvez opened this issue Mar 22, 2024 · 0 comments · Fixed by #15152
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.13.0

Comments

@mcarrilesgozalvez
Copy link

Describe the bug

CloseAriaLabel is not being applied to the close button when using DynamicDialog.

Environment

localhost, low envs and high envs

Reproducer

No response

Angular version

17

PrimeNG version

17.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

19.8.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@mcarrilesgozalvez mcarrilesgozalvez added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 22, 2024
@TaneliTuomola TaneliTuomola mentioned this issue Mar 22, 2024
Closed
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Mar 25, 2024
fix primefaces#15144 DynamicDialog get closeAriaLabel
4028ddc
@TaneliTuomola TaneliTuomola mentioned this issue Mar 25, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 29, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.13.0, 17.14.0 Mar 29, 2024
cetincakiroglu added a commit that referenced this issue Apr 9, 2024
@cetincakiroglu
Merge pull request #15152 from TaneliTuomola/issue-15144
8beb37c 
fix #15144 DynamicDialog get closeAriaLabel
@cetincakiroglu cetincakiroglu modified the milestones: 17.14.0, 17.13.0 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

fix #15144 DynamicDialog get closeAriaLabel TaneliTuomola/primeng
3 participants
@mcarrilesgozalvez @cetincakiroglu @mehmetcetin01140