Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: When removing the filter constraint it should not filter when showApplyButton is visible #15032

Closed
ymg2006 opened this issue Mar 13, 2024 · 4 comments · Fixed by #15007
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ymg2006
Copy link
Contributor

ymg2006 commented Mar 13, 2024

Describe the bug

Table: When removing the filter constraint it should not filter when showApplyButton is visible.
Remove Rule creates a backend request when apply is visible.
Attached images.
Screenshot 2024-03-13 144422
Screenshot 2024-03-13 144504

Environment

developement environment

Reproducer

No response

Angular version

17.0.x

PrimeNG version

17.10.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.19.1

Browser(s)

No response

Steps to reproduce the behavior

  1. click to remove rule on any filter with showApplyButton
  2. it will send request !!!!!!!!!!!!!!!!!!!

Expected behavior

  1. When show apply is visible, the responsibility for filtering is on the button so there is no need when removing a rule, it create a request.
@ymg2006 ymg2006 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 13, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 18, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

Remove rule filters the data again by the remaining filter constraints. So it re-filters the data both when you add a new rule and removing a rule. It's not a bug, it's made by design.

Thanks for reporting, closing the issue since it's not a bug.

@cetincakiroglu cetincakiroglu removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 19, 2024
@ymg2006
Copy link
Contributor Author

ymg2006 commented Mar 19, 2024

Hi,

Remove rule filters the data again by the remaining filter constraints. So it re-filters the data both when you add a new rule and removing a rule. It's not a bug, it's made by design.

Thanks for reporting, closing the issue since it's not a bug.

@cetincakiroglu the issue is not filtering, the issue is when the apply button is visible it makes a request. I copied this part of the code from the components codes. so either make them both filter without considering the apply button's visibility, or apply this to not create a request.
To explain more. it is not an issue that filters it. the issue is when you have the apply button it should wait until you press apply then filter.
I made this issue and created an fix commit for it. thanks.

@cetincakiroglu
Copy link
Contributor

I got your point now, thanks for the explanation.

@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 22, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE Issue's fix will be ported to supported LTS versions labels Mar 22, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 22, 2024
@cetincakiroglu
Copy link
Contributor

Fixed in #15007

@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants