Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table / Filter Row: Form elements missing aria-label #15024

Closed
TaneliTuomola opened this issue Mar 13, 2024 · 0 comments · Fixed by #15025
Closed

Table / Filter Row: Form elements missing aria-label #15024

TaneliTuomola opened this issue Mar 13, 2024 · 0 comments · Fixed by #15025
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request
Milestone
17.12.0

Comments

@TaneliTuomola
Copy link

Describe the bug

Missing aria-labels. Add aria-label attributes to the Table Filter Row form elements: p-columnFilter / p-columnFilterFormElement and its child components (input, p-inputNumber, p-triStateCheckbox p-calendar).

Environment

https://primeng.org/table#filter-row

Reproducer

No response

Angular version

17.0.0

PrimeNG version

17.10.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

https://primeng.org/table#filter-row

Expected behavior

No response
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 13, 2024
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Mar 13, 2024
fix primefaces#15024 table filter row aria-labels
1900d91
@TaneliTuomola TaneliTuomola mentioned this issue Mar 13, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.11.0 milestone Mar 14, 2024
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 14, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.11.0, 17.12.0 Mar 14, 2024
@cetincakiroglu cetincakiroglu added Type: New Feature Issue contains a new feature or new component request Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE labels Mar 19, 2024
cetincakiroglu added a commit that referenced this issue Mar 19, 2024
@cetincakiroglu
Merge pull request #15025 from TaneliTuomola/issue-15024
1d69273 
fix #15024 table filter row aria-labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
17.12.0
Development

Successfully merging a pull request may close this issue.

fix #15024 table filter row aria-labels TaneliTuomola/primeng
2 participants
@cetincakiroglu @TaneliTuomola