Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-contextMenu: Neither (onHide) Nor (onShow) event is being triggered when you right click twice continuously on same or other records #14962

Closed
ymg2006 opened this issue Mar 7, 2024 · 0 comments
Closed

p-contextMenu: Neither (onHide) Nor (onShow) event is being triggered when you right click twice continuously on same or other records #14962

ymg2006 opened this issue Mar 7, 2024 · 0 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.12.0

Comments

@ymg2006
Copy link
Contributor

ymg2006 commented Mar 7, 2024 •
edited
Loading

Describe the bug

Neither (onHide) Nor (onShow) event is being triggered when you right click twice continuously on same or other records.

Environment

Using primeng contextMenu in the application currently we are upgrading. We are using 16.9.1 and It is happening in latest version as well.

Reproducer

right click twice continuously it will not fire onShow or onHide second time.

Angular version

16.2.12

PrimeNG version

16.9.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.19.1

Browser(s)

No response

Steps to reproduce the behavior

1- bind (onShow) event to a method
2- put debugger inside method
3- right click two times
the second time the event is not triggered.

same applies to onHide event too.

Expected behavior

Same as primeng version v15, everytime you right click the onShow event gets triggered.
@ymg2006 ymg2006 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 7, 2024
ymg2006 pushed a commit to ymg2006/primeng that referenced this issue Mar 7, 2024
fixes primefaces#14962 - ContextMenu | onHide, onShow event is not be…
38af645 
…ing triggered when you right click twice continuously

the event should be called before calculations of position. the previous commit made some view bugs when items before onShow was modified
@ymg2006 ymg2006 mentioned this issue Mar 13, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.12.0 milestone Mar 14, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 18, 2024
cetincakiroglu added a commit that referenced this issue Mar 19, 2024
@cetincakiroglu
Merge pull request #14964 from ymg2006/master
38dd93a 
fixes #14962 - ContextMenu | onHide, onShow event is not being triggered when you right click twice continuously
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.12.0
Development

No branches or pull requests
3 participants
@ymg2006 @cetincakiroglu @mehmetcetin01140