-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pButton | Loading icon not removing #13489
Comments
Using ` |
I can confirm this issue. In my case it was the other way round, the spinner did not show up despite the loading property changing from false to true. When supplying the loadingIcon as @knightSarai mentioned, it works. When setting the loading property to true, it still disables the button. If setting the property to true before the button is rendered, it also shows the spinner. Maybe there is some issue with change detection here? |
Fix button loading issue #13489
Describe the bug
Only with the directive
pButton
, when the loading status of a button with a an icon changes, the loading indicator is not removed:Using the component
p-button
instead of the directive works.Environment
Windows
Reproducer
https://stackblitz.com/edit/gmhqyu?file=src%2Fapp%2Fdemo%2Fbutton-loading-demo.html
Angular version
16.X
PrimeNG version
16.2.0
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
16.20
Browser(s)
No response
Steps to reproduce the behavior
pButton
Expected behavior
At step 3,
pButton
should behave the same ap-button
.The text was updated successfully, but these errors were encountered: