Merge pull request #13676 from TheWrightDev/patch-1

Fix button loading issue #13489
primefaces · Sep 22, 2023 · 0bf5750 · 0bf5750 · vercel · Sep 22, 2023
2 parents 235cc49 + 4f8971f
commit 0bf5750
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/app/components/button/button.ts b/src/app/components/button/button.ts
@@ -205,13 +205,10 @@ export class ButtonDirective implements AfterViewInit, OnDestroy {
         let iconElement = DomHandler.findSingle(this.htmlElement, '.p-button-icon');
         let labelElement = DomHandler.findSingle(this.htmlElement, '.p-button-label');
 
-        if (!this.icon && !this.loading) {
-            iconElement && this.htmlElement.removeChild(iconElement);
-            return;
-        }
-
         if (this.loading && !this.loadingIcon && iconElement) {
             iconElement.innerHTML = this.spinnerIcon;
+        } else if (iconElement?.innerHTML) {
+            iconElement.innerHTML = '';
         }
 
         if (iconElement) {