Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In a Dynamic Dialog that is opened from another Dynamic Dialog, we can not press Tab to focus on the next field #10472

Closed
phuctvt opened this issue Aug 3, 2021 · 7 comments · Fixed by #15263
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@phuctvt
Copy link

phuctvt commented Aug 3, 2021

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Stackblitz Case (Bug Reports)
https://stackblitz.com/edit/primeng-dynamicdialog-demo-adhpi8

Current behavior

  1. Open a Dynamic Dialog from another Dynamic Dialog.
  2. There are some input fields in the dialog, when I press Tab, it will not focus on the next field.

You can try the issue by the link Stackblitz above.

Expected behavior
It should focus on the next input field.

What is the motivation / use case for changing the behavior?
If the dialog I mentioned is the dialog of filling some fields, the tab-focus-next-field behavior should works.

Please tell us about your environment: Stackblitz

  • Angular version: 11.0

  • PrimeNG version: 11.3.0

  • Browser: I tested on Chrome and Firefox

  • Language: TypeScript

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Aug 4, 2021
@tisys-parceiros
Copy link

was this problem resolved?

@miguelarcjr
Copy link

I have the same problem

@nev-21
Copy link

nev-21 commented Apr 30, 2022

me too, same problem

@mselerin
Copy link
Contributor

This seems related to #9329 for which I have a workaround :-)

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@mselerin
Copy link
Contributor

I have just test this bug and it is still present :-(

So my PR is still relevant.

@mertsincan mertsincan reopened this Nov 11, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 11, 2022
@jayee
Copy link

jayee commented Jan 25, 2024

This is still a problem in 17.3.3.

The tab-key does not cycle between focusable elements correctly. It gets stuck on the close-x when using tab-key. It can shift-tab one step.

BGBRWR added a commit to BGBRWR/primeng that referenced this issue Apr 11, 2024
@cetincakiroglu cetincakiroglu added this to the 17.14.0 milestone Apr 18, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants