Skip to content

Commit

Permalink
Merge pull request #14268 from SoyDiego/fix-autocomplete-change-detec…
Browse files Browse the repository at this point in the history
…tion

Fix(AutoComplete): Change Detection Issue
  • Loading branch information
cetincakiroglu authored Dec 6, 2023
2 parents 4a4eae7 + 960482b commit d753dcc
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 7 deletions.
1 change: 1 addition & 0 deletions src/app/components/autocomplete/autocomplete.ts
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,7 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr

ngOnInit() {
this.id = this.id || UniqueComponentId();
this.cd.detectChanges();
}

ngAfterViewChecked() {
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/image/image.ts
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ export class Image implements AfterContentInit {
imagePreviewStyle() {
return { transform: 'rotate(' + this.rotate + 'deg) scale(' + this.scale + ')' };
}

get zoomImageAriaLabel() {
return this.config.translation.aria ? this.config.translation.aria.zoomImage : undefined;
}
Expand Down
4 changes: 1 addition & 3 deletions src/app/components/toast/toast.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export class ToastItem implements AfterViewInit, OnDestroy {

timeout: any;

constructor(private zone: NgZone,private config: PrimeNGConfig) {}
constructor(private zone: NgZone, private config: PrimeNGConfig) {}

ngAfterViewInit() {
this.initTimeout();
Expand Down Expand Up @@ -192,8 +192,6 @@ export class ToastItem implements AfterViewInit, OnDestroy {
ngOnDestroy() {
this.clearTimeout();
}


}

/**
Expand Down
4 changes: 1 addition & 3 deletions src/app/showcase/doc/Image/accessibilitydoc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ import { Component } from '@angular/core';
selector: 'accessibility-doc',
template: ` <app-docsectiontext>
<h3>Screen Reader</h3>
<p>
The preview button is a native <i>button</i> element with an <i>aria-label</i> that refers to the <i>aria.zoomImage</i> property of the <a href="/configuration/#locale">locale</a> API by default.
</p>
<p>The preview button is a native <i>button</i> element with an <i>aria-label</i> that refers to the <i>aria.zoomImage</i> property of the <a href="/configuration/#locale">locale</a> API by default.</p>
<p>When preview is active, <i>dialog</i> role with <i>aria-modal</i> is applied to the overlay image container.</p>
<p>Button controls use <i>aria.rotateRight</i>, <i>aria.rotateLeft</i>, <i>aria.zoomIn</i>, <i>aria.zoomOut</i> and <i>aria.close</i> from the <a href="/configuration/#locale">locale</a> API as <i>aria-label</i>.</p>
<h3>ButtonBar Keyboard Support</h3>
Expand Down

1 comment on commit d753dcc

@vercel
Copy link

@vercel vercel bot commented on d753dcc Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment failed with the following error:

The value for maxDuration must be between 1 second and 10 seconds, in order to increase this limit upgrade your plan: https://vercel.com/pricing

Please sign in to comment.