Skip to content

Commit

Permalink
Merge pull request #15243 from BGBRWR/expandedRowKeys-is-getting-set-…
Browse files Browse the repository at this point in the history
…to-a-boolean

fix(#15241): removed invalid transforms on Inputs
  • Loading branch information
cetincakiroglu authored Apr 18, 2024
2 parents 41890a4 + 9413507 commit 96e657c
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion src/app/components/dataview/dataview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export class DataView implements OnInit, AfterContentInit, OnDestroy, BlockableU
* Function to optimize the dom operations by delegating to ngForTrackBy, default algorithm checks for object identity.
* @group Props
*/
@Input({ transform: numberAttribute }) trackBy: Function = (index: number, item: any) => item;
@Input() trackBy: Function = (index: number, item: any) => item;
/**
* Comma separated list of fields in the object graph to search against.
* @group Props
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/inputnumber/inputnumber.ts
Original file line number Diff line number Diff line change
Expand Up @@ -371,12 +371,12 @@ export class InputNumber implements OnInit, AfterContentInit, OnChanges, Control
* The minimum number of fraction digits to use. Possible values are from 0 to 20; the default for plain number and percent formatting is 0; the default for currency formatting is the number of minor unit digits provided by the ISO 4217 currency code list (2 if the list doesn't provide that information).
* @group Props
*/
@Input({ transform: numberAttribute }) minFractionDigits: number | undefined;
@Input() minFractionDigits: number | undefined;
/**
* The maximum number of fraction digits to use. Possible values are from 0 to 20; the default for plain number formatting is the larger of minimumFractionDigits and 3; the default for currency formatting is the larger of minimumFractionDigits and the number of minor unit digits provided by the ISO 4217 currency code list (2 if the list doesn't provide that information).
* @group Props
*/
@Input({ transform: numberAttribute }) maxFractionDigits: number | undefined;
@Input() maxFractionDigits: number | undefined;
/**
* Text to display before the value.
* @group Props
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/orderlist/orderlist.ts
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export class OrderList implements AfterViewChecked, AfterContentInit {
* Function to optimize the dom operations by delegating to ngForTrackBy, default algorithm checks for object identity.
* @group Props
*/
@Input({ transform: numberAttribute }) trackBy: Function = (index: number, item: any) => item;
@Input() trackBy: Function = (index: number, item: any) => item;

/**
* A list of values that are currently selected.
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/picklist/picklist.ts
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ export class PickList implements AfterViewChecked, AfterContentInit {
* Function to optimize the dom operations by delegating to ngForTrackBy, default algorithm checks for object identity. Use sourceTrackBy or targetTrackBy in case different algorithms are needed per list.
* @group Props
*/
@Input({ transform: numberAttribute }) trackBy: Function = (index: number, item: any) => item;
@Input() trackBy: Function = (index: number, item: any) => item;
/**
* Function to optimize the dom operations by delegating to ngForTrackBy in source list, default algorithm checks for object identity.
* @group Props
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/slidemenu/slidemenu.ts
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export class SlideMenuSub {

@Input() easing: string = 'ease-out';

@Input() effectDuration: any;
@Input({ transform: numberAttribute }) effectDuration: number;

@Input({ transform: booleanAttribute }) autoDisplay: boolean | undefined;

Expand Down Expand Up @@ -406,7 +406,7 @@ export class SlideMenu implements OnInit, AfterContentInit, OnDestroy {
* Duration of the sliding animation in milliseconds.
* @group Props
*/
@Input({ transform: numberAttribute }) effectDuration: any = 250;
@Input({ transform: numberAttribute }) effectDuration: number = 250;
/**
* Easing animation to use for sliding.
* @group Props
Expand Down
16 changes: 8 additions & 8 deletions src/app/components/table/table.ts
Original file line number Diff line number Diff line change
Expand Up @@ -484,12 +484,12 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable
* Defines if the row is selectable.
* @group Props
*/
@Input() rowSelectable: boolean | Function | undefined | any;
@Input() rowSelectable: (row: { data: any; index: number }) => boolean | undefined;
/**
* Function to optimize the dom operations by delegating to ngForTrackBy, default algorithm checks for object identity.
* @group Props
*/
@Input({ transform: numberAttribute }) rowTrackBy: Function = (index: number, item: any) => item;
@Input() rowTrackBy: Function = (index: number, item: any) => item;
/**
* Defines if data is loaded and interacted with in lazy manner.
* @group Props
Expand Down Expand Up @@ -539,12 +539,12 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable
* Map instance to keep the expanded rows where key of the map is the data key of the row.
* @group Props
*/
@Input({ transform: booleanAttribute }) expandedRowKeys: { [s: string]: boolean } = {};
@Input() expandedRowKeys: { [s: string]: boolean } = {};
/**
* Map instance to keep the rows being edited where key of the map is the data key of the row.
* @group Props
*/
@Input({ transform: booleanAttribute }) editingRowKeys: { [s: string]: boolean } = {};
@Input() editingRowKeys: { [s: string]: boolean } = {};
/**
* Whether multiple rows can be expanded at any time. Valid values are "multiple" and "single".
* @group Props
Expand Down Expand Up @@ -5169,12 +5169,12 @@ export class ColumnFilter implements AfterContentInit {
* Defines minimum fraction of digits.
* @group Props
*/
@Input({ transform: numberAttribute }) minFractionDigits: number | undefined;
@Input() minFractionDigits: number | undefined;
/**
* Defines maximum fraction of digits.
* @group Props
*/
@Input({ transform: numberAttribute }) maxFractionDigits: number | undefined;
@Input() maxFractionDigits: number | undefined;
/**
* Defines prefix of the filter.
* @group Props
Expand Down Expand Up @@ -5807,9 +5807,9 @@ export class ColumnFilterFormElement implements OnInit {

@Input() placeholder: string | undefined;

@Input({ transform: numberAttribute }) minFractionDigits: number | undefined;
@Input() minFractionDigits: number | undefined;

@Input({ transform: numberAttribute }) maxFractionDigits: number | undefined;
@Input() maxFractionDigits: number | undefined;

@Input() prefix: string | undefined;

Expand Down
2 changes: 1 addition & 1 deletion src/app/components/tree/tree.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1010,7 +1010,7 @@ export class Tree implements OnInit, AfterContentInit, OnChanges, OnDestroy, Blo
* Function to optimize the node list rendering, default algorithm checks for object identity.
* @group Props
*/
@Input({ transform: numberAttribute }) trackBy: Function = (index: number, item: any) => item;
@Input() trackBy: Function = (index: number, item: any) => item;
/**
* Height of the node.
* @group Props
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/treetable/treetable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ export class TreeTable implements AfterContentInit, OnInit, OnDestroy, Blockable
* Function to optimize the dom operations by delegating to ngForTrackBy, default algorithm checks for object identity.
* @group Props
*/
@Input({ transform: numberAttribute }) rowTrackBy: Function = (index: number, item: any) => item;
@Input() rowTrackBy: Function = (index: number, item: any) => item;
/**
* An array of FilterMetadata objects to provide external filters.
* @group Props
Expand Down
6 changes: 3 additions & 3 deletions src/app/showcase/doc/apidoc/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -20810,7 +20810,7 @@
"name": "effectDuration",
"optional": false,
"readonly": false,
"type": "any",
"type": "number",
"default": "250",
"description": "Duration of the sliding animation in milliseconds."
},
Expand Down Expand Up @@ -22643,7 +22643,7 @@
"name": "rowSelectable",
"optional": false,
"readonly": false,
"type": "any",
"type": "(row: { data: any; index: number }) => boolean",
"description": "Defines if the row is selectable."
},
{
Expand Down Expand Up @@ -28773,4 +28773,4 @@
}
}
}
}
}

0 comments on commit 96e657c

Please sign in to comment.