PR feedback

primefaces · Apr 12, 2024 · 57f02bc · 57f02bc
1 parent 6c51497
commit 57f02bc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/app/components/messages/messages.ts b/src/app/components/messages/messages.ts
@@ -58,9 +58,9 @@ import { Subscription, timer } from 'rxjs';
                         </ng-container>
                         <ng-template #escapeOut>
                             <span *ngIf="msg.summary" class="p-message-summary" [attr.data-pc-section]="'summary'">{{ msg.summary }}</span>
-                            <span *ngIf="msg.detail" class="p-message-detail" [attr.data-pc-section]="'detail'">{{ msg.detail }} test</span>
+                            <span *ngIf="msg.detail" class="p-message-detail" [attr.data-pc-section]="'detail'">{{ msg.detail }}</span>
                         </ng-template>
-                        <button class="p-message-close p-link" (click)="removeMessage(i)" *ngIf="msg.closable || (closable && msg.closable)" type="button" pRipple [attr.aria-label]="closeAriaLabel" [attr.data-pc-section]="'closebutton'">
+                        <button class="p-message-close p-link" (click)="removeMessage(i)" *ngIf="closable && (msg.closable ?? true)" type="button" pRipple [attr.aria-label]="closeAriaLabel" [attr.data-pc-section]="'closebutton'">
                             <TimesIcon [styleClass]="'p-message-close-icon'" [attr.data-pc-section]="'closeicon'" />
                         </button>
                     </div>

diff --git a/src/app/showcase/doc/messages/servicedoc.ts b/src/app/showcase/doc/messages/servicedoc.ts
@@ -32,8 +32,8 @@ export class ServiceDoc {
 
     addMultiple() {
         this.messageService.addAll([
-            { severity: 'success', summary: 'Service Message', detail: 'Via MessageService', closable: true },
-            { severity: 'info', summary: 'Info Message', detail: 'Via MessageService', closable: false }
+            { severity: 'success', summary: 'Service Message', detail: 'Via MessageService' },
+            { severity: 'info', summary: 'Info Message', detail: 'Via MessageService' }
         ]);
     }
 
@@ -75,8 +75,8 @@ export class MessagesServiceDemo {
 
     addMultiple() {
         this.messageService.addAll([
-            { severity: 'success', summary: 'Service Message', detail: 'Via MessageService', closable: true },
-            { severity: 'info', summary: 'Info Message', detail: 'Via MessageService', closable: false }
+            { severity: 'success', summary: 'Service Message', detail: 'Via MessageService' },
+            { severity: 'info', summary: 'Info Message', detail: 'Via MessageService' }
         ]);
     }