Fix: Menu(16795): appendChild param order reversed

primefaces · Nov 20, 2024 · 32d0e0a · 32d0e0a
1 parent 6d18e1e
commit 32d0e0a
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/packages/primeng/src/drawer/drawer.ts b/packages/primeng/src/drawer/drawer.ts
@@ -402,7 +402,7 @@ export class Drawer extends BaseComponent implements AfterViewInit, OnDestroy {
     appendContainer() {
         if (this.appendTo) {
             if (this.appendTo === 'body') this.renderer.appendChild(this.document.body, this.container);
-            else appendChild(this.container, this.appendTo);
+            else appendChild(this.appendTo, this.container);
         }
     }
 

diff --git a/packages/primeng/src/menu/menu.ts b/packages/primeng/src/menu/menu.ts
@@ -519,7 +519,7 @@ export class Menu extends BaseComponent implements OnDestroy {
     appendOverlay() {
         if (this.appendTo) {
             if (this.appendTo === 'body') this.renderer.appendChild(this.document.body, this.container);
-            else appendChild(this.container, this.appendTo);
+            else appendChild(this.appendTo, this.container);
         }
     }
 

diff --git a/packages/primeng/src/overlaypanel/overlaypanel.ts b/packages/primeng/src/overlaypanel/overlaypanel.ts
@@ -316,7 +316,7 @@ export class OverlayPanel extends BaseComponent implements AfterContentInit, OnD
     appendContainer() {
         if (this.appendTo) {
             if (this.appendTo === 'body') this.renderer.appendChild(this.document.body, this.container);
-            else appendChild(this.container, this.appendTo);
+            else appendChild(this.appendTo, this.container);
         }
     }
 

diff --git a/packages/primeng/src/popover/popover.ts b/packages/primeng/src/popover/popover.ts
@@ -282,7 +282,7 @@ export class Popover extends BaseComponent implements OnDestroy {
     appendContainer() {
         if (this.appendTo) {
             if (this.appendTo === 'body') this.renderer.appendChild(this.document.body, this.container);
-            else appendChild(this.container, this.appendTo);
+            else appendChild(this.appendTo, this.container);
         }
     }
 

diff --git a/packages/primeng/src/sidebar/sidebar.ts b/packages/primeng/src/sidebar/sidebar.ts
@@ -377,7 +377,7 @@ export class Sidebar extends BaseComponent implements AfterViewInit, AfterConten
 
     appendContainer() {
         if (this.appendTo) {
-            return this.appendTo === 'body' ? this.renderer.appendChild(this.document.body, this.container) : appendChild(this.container, this.appendTo);
+            return this.appendTo === 'body' ? this.renderer.appendChild(this.document.body, this.container) : appendChild(this.appendTo, this.container);
         }
     }
 

diff --git a/packages/primeng/src/tieredmenu/tieredmenu.ts b/packages/primeng/src/tieredmenu/tieredmenu.ts
@@ -972,7 +972,7 @@ export class TieredMenu extends BaseComponent implements OnInit, OnDestroy {
     appendOverlay() {
         if (this.appendTo) {
             if (this.appendTo === 'body') this.renderer.appendChild(this.document.body, this.container);
-            else appendChild(this.container, this.appendTo);
+            else appendChild(this.appendTo, this.container);
         }
     }