Merge branch 'master' of https://github.com/primefaces/primeng

primefaces · Oct 25, 2023 · 29bd828 · 29bd828 · vercel · Oct 25, 2023
2 parents 255fa42 + 21c5fa8
commit 29bd828
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 3 deletions.
diff --git a/src/app/components/galleria/galleria.ts b/src/app/components/galleria/galleria.ts
@@ -674,7 +674,7 @@ export class GalleriaItemSlot {
                     tabindex="0"
                     (click)="onIndicatorClick(index)"
                     (mouseenter)="onIndicatorMouseEnter(index)"
-                    (keydown)="onIndicatorKeyDown(event, index)"
+                    (keydown)="onIndicatorKeyDown($event, index)"
                     [ngClass]="{ 'p-galleria-indicator': true, 'p-highlight': isIndicatorItemActive(index) }"
                     [attr.aria-label]="ariaPageLabel(index + 1)"
                     [attr.aria-selected]="activeIndex === index"

diff --git a/src/app/components/image/image.ts b/src/app/components/image/image.ts
@@ -22,7 +22,7 @@ import { FocusTrapModule } from 'primeng/focustrap';
     selector: 'p-image',
     template: `
         <span [ngClass]="containerClass()" [class]="styleClass" [ngStyle]="style">
-            <img [attr.src]="src" [attr.srcset]="srcSet" [attr.sizes]="sizes" [attr.alt]="alt" [attr.width]="width" [attr.height]="height" [ngStyle]="imageStyle" [class]="imageClass" (error)="imageError($event)" />
+            <img [attr.src]="src" [attr.srcset]="srcSet" [attr.sizes]="sizes" [attr.alt]="alt" [attr.width]="width" [attr.height]="height" [attr.loading]="loading" [ngStyle]="imageStyle" [class]="imageClass" (error)="imageError($event)" />
             <button type="button" class="p-image-preview-indicator" (click)="onImageClick()" #previewButton [ngStyle]="{ height: height + 'px', width: width + 'px' }" style="border: 'none';">
                 <ng-container *ngIf="indicatorTemplate; else defaultTemplate">
                     <ng-container *ngTemplateOutlet="indicatorTemplate"></ng-container>
@@ -144,6 +144,11 @@ export class Image implements AfterContentInit {
      * @group Props
      */
     @Input() height: string | undefined;
+    /**
+     * Attribute of the image element.
+     * @group Props
+     */
+    @Input() loading: 'lazy' | 'eager' | undefined;
     /**
      * Target element to attach the dialog, valid values are "body" or a local ng-template variable of another element (note: use binding with brackets for template variables, e.g. [appendTo]="mydiv" for a div element having #mydiv as variable name).
      * @group Props

diff --git a/src/app/components/overlaypanel/overlaypanel.ts b/src/app/components/overlaypanel/overlaypanel.ts
@@ -8,6 +8,7 @@ import {
     ContentChildren,
     ElementRef,
     EventEmitter,
+    HostListener,
     Inject,
     Input,
     NgModule,
@@ -422,6 +423,11 @@ export class OverlayPanel implements AfterContentInit, OnDestroy {
         this.hide();
         event.preventDefault();
     }
+
+    @HostListener('document:keydown.escape', ['$event'])
+    onEscapeKeydown(event: KeyboardEvent) {
+        this.hide()
+    }
 
     onWindowResize() {
         if (this.overlayVisible && !DomHandler.isTouchDevice()) {

diff --git a/src/app/components/tabview/tabview.ts b/src/app/components/tabview/tabview.ts
@@ -317,7 +317,7 @@ export class TabPanel implements AfterContentInit, OnDestroy {
                                 </a>
                             </li>
                         </ng-template>
-                        <li #inkbar class="p-tabview-ink-bar" [attr.data-pc-section]="'inkbar'"></li>
+                        <li #inkbar class="p-tabview-ink-bar" role="presentation" aria-hidden="true" [attr.data-pc-section]="'inkbar'"></li>
                     </ul>
                 </div>
                 <button

diff --git a/src/app/showcase/layout/doc/codeeditor/templates.ts b/src/app/showcase/layout/doc/codeeditor/templates.ts
@@ -492,6 +492,7 @@ import { CheckboxModule } from 'primeng/checkbox';
 import { ChipModule } from 'primeng/chip';
 import { ChipsModule } from 'primeng/chips';
 import { ConfirmDialogModule } from 'primeng/confirmdialog';
+import { ConfirmPopupModule } from 'primeng/confirmpopup';
 import { ColorPickerModule } from 'primeng/colorpicker';
 import { ContextMenuModule } from 'primeng/contextmenu';
 import { DataViewModule } from 'primeng/dataview';
@@ -590,6 +591,7 @@ ${serviceImports}
     ChipModule,
     ColorPickerModule,
     ConfirmDialogModule,
+    ConfirmPopupModule,
     ContextMenuModule,
     VirtualScrollerModule,
     DataViewModule,
-Original file line number
+Diff line change
@@ Expand Up @@
                                     </a>
                                 </li>
                             </ng-template>
-                            <li #inkbar class="p-tabview-ink-bar" [attr.data-pc-section]="'inkbar'"></li>
+                            <li #inkbar class="p-tabview-ink-bar" role="presentation" aria-hidden="true" [attr.data-pc-section]="'inkbar'"></li>
                         </ul>
                     </div>
                     <button
@@ Expand Down @@