Merge pull request #14666 from TaneliTuomola/issue-14608

fix #14608 p-ColumnFilter aria-label
primefaces · Feb 1, 2024 · 1abcc8e · 1abcc8e
2 parents c2a6730 + 618cf72
commit 1abcc8e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/app/components/api/translationkeys.ts b/src/app/components/api/translationkeys.ts
@@ -41,7 +41,7 @@ export class TranslationKeys {
     public static readonly PASSWORD_PROMPT = 'passwordPrompt';
     public static readonly EMPTY_MESSAGE = 'emptyMessage';
     public static readonly EMPTY_FILTER_MESSAGE = 'emptyFilterMessage';
-    public static readonly SHOW_FILTER_MENU = 'Show Filter Menu';
-    public static readonly HIDE_FILTER_MENU = 'Hide Filter Menu';
+    public static readonly SHOW_FILTER_MENU = 'showFilterMenu';
+    public static readonly HIDE_FILTER_MENU = 'hideFilterMenu';
     public static readonly SELECTION_MESSAGE = '{0} items selected';
 }
diff --git a/src/app/components/table/table.ts b/src/app/components/table/table.ts
@@ -4947,7 +4947,7 @@ export class ReorderableRow implements AfterViewInit {
                 type="button"
                 class="p-column-filter-menu-button p-link"
                 aria-haspopup="true"
-                [attr.aria-label]="showMenuButtonLabel"
+                [attr.aria-label]="filterMenuButtonAriaLabel"
                 [attr.aria-controls]="overlayId"
                 [attr.aria-expanded]="overlayVisible"
                 [ngClass]="{ 'p-column-filter-menu-button-open': overlayVisible, 'p-column-filter-menu-button-active': hasFilter() }"
@@ -5279,7 +5279,7 @@ export class ColumnFilter implements AfterContentInit {
     }
 
     get filterMenuButtonAriaLabel() {
-        return this.config.translation ? (this.overlayVisible ? this.config.translation.aria.showFilterMenu : this.config.translation.aria.hideFilterMenu) : undefined;
+        return this.config.translation ? (this.overlayVisible ? this.config.translation.aria.hideFilterMenu : this.config.translation.aria.showFilterMenu) : undefined;
     }
 
     get removeRuleButtonAriaLabel() {