-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ar.json #171
Update ar.json #171
Conversation
support latest primeng v17.18
Going to reject this. All the labels you removed are in use in PrimeFaces JsF and PrimeReact. PrimeNG needs to be updated to use all these labels you removed Please only add the missing primeNG labels and make sure they are in alphabetical order |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
I reverted the deletion of the labels that were not used in PrimeNG, and sorted the new additions in alphabetical order |
"after": "بعد", | ||
"before": "قبل", | ||
"is": "يكون", | ||
"isNot": "ليس", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are wrong PrimeNG should be using the following which are already defined in the file...
"dateAfter": "التاريخ بعد",
"dateBefore": "التاريخ قبل",
"dateFormat": "شهر/يوم/سنة",
"dateIs": "التاريخ هو",
"dateIsNot": "التاريخ ليس",
See PrimeNG bug: primefaces/primeng#14446
@@ -163,14 +170,17 @@ | |||
"pageLabel": "صفحة {page}", | |||
"passwordHide": "اخفاء كلمة المرور", | |||
"passwordShow": "عرض كلمة المرور", | |||
"prevPageLabel": "الصفحة السابقة", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect there is already previousPageLabel
please report to PrimeNG. See: #170
looks like PrimeNG is not synced with the rest of PrimeTek in regards to this file schema |
@MuhAssar yes I agree. |
support latest primeng v17.18