Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ar.json #171

Closed
wants to merge 5 commits into from
Closed

Update ar.json #171

wants to merge 5 commits into from

Conversation

MuhAssar
Copy link

support latest primeng v17.18

support latest primeng v17.18
@melloware
Copy link
Member

melloware commented May 31, 2024

Going to reject this. All the labels you removed are in use in PrimeFaces JsF and PrimeReact. PrimeNG needs to be updated to use all these labels you removed

Please only add the missing primeNG labels and make sure they are in alphabetical order

Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@melloware melloware added the invalid This doesn't seem right label May 31, 2024
@MuhAssar
Copy link
Author

MuhAssar commented May 31, 2024

I reverted the deletion of the labels that were not used in PrimeNG, and sorted the new additions in alphabetical order

@MuhAssar MuhAssar requested a review from melloware May 31, 2024 16:12
"after": "بعد",
"before": "قبل",
"is": "يكون",
"isNot": "ليس",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are wrong PrimeNG should be using the following which are already defined in the file...

    "dateAfter": "التاريخ بعد",
    "dateBefore": "التاريخ قبل",
    "dateFormat": "شهر/يوم/سنة",
    "dateIs": "التاريخ هو",
    "dateIsNot": "التاريخ ليس",

See PrimeNG bug: primefaces/primeng#14446

@@ -163,14 +170,17 @@
"pageLabel": "صفحة {page}",
"passwordHide": "اخفاء كلمة المرور",
"passwordShow": "عرض كلمة المرور",
"prevPageLabel": "الصفحة السابقة",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect there is already previousPageLabel please report to PrimeNG. See: #170

@MuhAssar MuhAssar closed this May 31, 2024
@MuhAssar MuhAssar deleted the patch-1 branch May 31, 2024 19:12
@MuhAssar
Copy link
Author

looks like PrimeNG is not synced with the rest of PrimeTek in regards to this file schema

@melloware
Copy link
Member

@MuhAssar yes I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants