-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust translations for PrimeNG 17 #143
Conversation
@marcschroeder sorry can you only ADD items and not delete items. The items you have deleted are used by PrimeReact and PrimeFaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
"is": "Is", | ||
"after": "After", | ||
"before": "Before", | ||
"isNot": "Is not", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be wrong but should't PrimeNg be using these..
"dateIs": "Date is",
"dateIsNot": "Date is not",
"dateBefore": "Date is before",
"dateAfter": "Date is after",
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed https://github.com/primefaces/primeng/blob/master/src/app/components/api/translation.ts for the keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I looked at the source code and those 4 are not in any other lib PrimeFaces, PrimeVue or PrimeReact.
It seems they are just shortcuts to the real methods.
is: (value: any, filter: any, filterLocale?: any): boolean => {
return this.filters.equals(value, filter, filterLocale);
},
isNot: (value: any, filter: any, filterLocale?: any): boolean => {
return this.filters.notEquals(value, filter, filterLocale);
},
before: (value: any, filter: any, filterLocale?: any): boolean => {
return this.filters.lt(value, filter, filterLocale);
},
after: (value: any, filter: any, filterLocale?: any): boolean => {
return this.filters.gt(value, filter, filterLocale);
},
So I actually think these 4 are deprecated in PrimeNG and replaced with the 4 values that have translations so somewhere along the lines PrimeTek made all the libraries in line and left these 4 for backwards compatibility but they should probably be marked deprecated.
I just opened this PrimeNG ticket: primefaces/primeng#14446
No description provided.