Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

map_object script ID renaming #337

Merged
merged 2 commits into from
Oct 1, 2024
Merged

map_object script ID renaming #337

merged 2 commits into from
Oct 1, 2024

Conversation

red031000
Copy link
Member

formatted this using clang-format 20, it appears to have removed some brackets and swapped around some conditions, hopefully that's alright

some small cleanup from my previous work that I forgot to commit apparently

PikalaxALT
PikalaxALT approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@PikalaxALT PikalaxALT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm though this does highlight behavioral differences between clang-format-17 and clang-format-20

@PikalaxALT PikalaxALT merged commit 4b889fa into pret:master Oct 1, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
@PikalaxALT
Merge pull request #337 from red031000/master
6c94b33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikalaxALT PikalaxALT PikalaxALT approved these changes

@adrienntindall adrienntindall Awaiting requested review from adrienntindall

Assignees
No one assigned
Labels
CLEANUP DOCUMENTATION
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@red031000 @PikalaxALT