Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mic Test Overlay #320

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Mic Test Overlay #320

wants to merge 12 commits into from

Conversation

adrienntindall
Copy link
Collaborator

Follows from #311

The function I'm leaving on is breaking my brain so gonna commit and document some of the structs to the best of my ability
@PikalaxALT
Copy link
Collaborator

Stale pull request warning

This pull request has had no activity for 60 days and has been marked stale. It will be closed after a further 30 days of inactivity.

@red031000
Copy link
Member

this is literally a draft PR
draft PRs aren't subject to stale, I thought that was the entire idea

@PikalaxALT PikalaxALT removed the stale label Sep 15, 2024
@adrienntindall adrienntindall marked this pull request as ready for review September 26, 2024 19:38
Copy link
Collaborator

@PikalaxALT PikalaxALT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't even gotten to your new stuff but apparently clang-format is drunker than i've ever been

@@ -1,9 +0,0 @@
#!/bin/sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore this

uses: pierotofy/set-swap-space@master
with:
swap-size-gb: 19
- name: Build ROM
Copy link
Collaborator

@PikalaxALT PikalaxALT Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this from the rejected build-nonmatching PR? If so, please revert

@@ -389,7 +389,7 @@
#define FIRST_MULCH_IDX ITEM_GROWTH_MULCH
#define LAST_MULCH_IDX ITEM_GOOEY_MULCH
#define NUM_MULCHES (LAST_MULCH_IDX - FIRST_MULCH_IDX + 1)
#define MULCH_IDX(mulch) ((mulch) - FIRST_MULCH_IDX + 1)
#define MULCH_IDX(mulch) ((mulch)-FIRST_MULCH_IDX + 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

@@ -506,7 +506,7 @@
#define FIRST_BERRY_IDX ITEM_CHERI_BERRY
#define LAST_BERRY_IDX ITEM_ROWAP_BERRY
#define NUM_BERRIES (LAST_BERRY_IDX - FIRST_BERRY_IDX + 1)
#define BERRY_IDX(berry) ((berry) - FIRST_BERRY_IDX + 1)
#define BERRY_IDX(berry) ((berry)-FIRST_BERRY_IDX + 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

@@ -79,11 +79,11 @@
#define std_apricorn_tree 2800

#define _std_npc_trainer 3000
#define std_trainer(trainer) ((trainer) - FIRST_TRAINER_INDEX + _std_npc_trainer)
#define std_trainer(trainer) ((trainer)-FIRST_TRAINER_INDEX + _std_npc_trainer)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etc

{ 5, 0 },
{ 0, 5 },
{ 5, 5 },
{0, 0},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format, go home, you're drunk. and this is coming from someone who is drunk and ain't sobering up anytime soon.

{ ITEM_DEEPSEATOOTH, 1, 0, 0, 38 },
{ ITEM_DEEPSEASCALE, 1, 0, 0, 229 },
{ ITEM_PP_MAX, 1, 0, 0, 230 },
{ITEM_POTION, 1, 0, 0, 0 },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my tea's gone cold i'm wonderin' why i got out of bed at all

{ LANGUAGE_ITALIAN, msg_0287_ciao },
{ LANGUAGE_GERMAN, msg_0287_hallo },
{ LANGUAGE_SPANISH, msg_0287_hola },
{LANGUAGE_JAPANESE, msg_0287_konnichiwa},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my cold's gone tea i'm why wonderin' f*** me in the a**

echo "linting made changes to source files; aborting commit"
exit 1
fi
#!/bin/sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix line endings? should be \n, not \r\n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants