Split & decompile overlay 16 (berry growth) #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienntindall
requested changes
Aug 13, 2023
tgsm
force-pushed
the
overlay_16
branch
3 times, most recently
from
996215e
to
99498aa
Compare
adrienntindall
requested changes
Aug 16, 2023
| @@ -360,7 +372,7 @@ u16 GetTotalBerryQuantity(Bag *bag, HeapID heapId) { | |||
| u16 GetTotalMulchQuantity(Bag *bag, HeapID heapId) { | |||
| s32 i; | |||
| u16 total; | |||
| for (total = 0, i = 0; i < 4; i++) { | |||
| for (total = 0, i = 0; i < NUM_MULCHES; i++) { | |||
There was a problem hiding this comment.
NUM_ to refer to the number of elements in a set is weird, because you could also have numMulches which stores the current amount of mulches. TODO investigate what naming we want.
Co-Authored-By: PikalaxALT <[email protected]>
Source: Bulbapedia
adrienntindall
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.