Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish functions for overlay_12_0224E4FC.c #195

Merged
merged 27 commits into from
Jul 18, 2023

Conversation

adrienntindall
Copy link
Collaborator

Data coming soon but there is one with 145 elements in it that Im too lazy to do atm

src/battle/battle_command.c Outdated Show resolved Hide resolved
src/battle/overlay_12_0224E4FC.c Show resolved Hide resolved
src/battle/overlay_12_0224E4FC.c Outdated Show resolved Hide resolved
src/battle/overlay_12_0224E4FC.c Outdated Show resolved Hide resolved
src/battle/overlay_12_0224E4FC.c Outdated Show resolved Hide resolved
adrienntindall and others added 2 commits July 11, 2023 23:11
Also forgor to credit Lhea as a co-author for providing me with battleStatus consts from PlatEngine

Co-Authored-By: Rachel <[email protected]>
@BluRosie
Copy link
Contributor

i'm on mobile rn my apologies but that one function BattleCtx_IsIdenticalToCurrentMove is for checking two-turn move effects and is the function that erroneously checks fire fang and allows it to bypass wonder guard

@adrienntindall
Copy link
Collaborator Author

i'm on mobile rn my apologies but that one function BattleCtx_IsIdenticalToCurrentMove is for checking two-turn move effects and is the function that erroneously checks fire fang and allows it to bypass wonder guard

actually I think the function you're talking about is ov12_02258440 assuming your documentation of MOVE_EFFECT_FLINCH_BURN_HIT is correct

include/constants/battle_script.h Outdated Show resolved Hide resolved
include/constants/battle_script.h Outdated Show resolved Hide resolved
include/constants/move_effects.h Show resolved Hide resolved
src/battle/overlay_12_0224E4FC.c Show resolved Hide resolved
src/battle/overlay_12_0224E4FC.c Outdated Show resolved Hide resolved
src/battle/overlay_12_0224E4FC.c Outdated Show resolved Hide resolved
src/battle/overlay_12_0224E4FC.c Outdated Show resolved Hide resolved
src/battle/overlay_12_0224E4FC.c Show resolved Hide resolved
src/battle/overlay_12_0224E4FC.c Show resolved Hide resolved
src/battle/overlay_12_0224E4FC.c Show resolved Hide resolved
src/battle/battle_controller_player.c Show resolved Hide resolved
src/battle/battle_controller_player.c Outdated Show resolved Hide resolved
src/battle/battle_controller_player.c Show resolved Hide resolved
src/battle/battle_controller_player.c Outdated Show resolved Hide resolved
src/battle/battle_controller_player.c Show resolved Hide resolved
src/battle/battle_controller_player.c Outdated Show resolved Hide resolved
src/battle/battle_controller_player.c Outdated Show resolved Hide resolved
src/battle/battle_controller_player.c Outdated Show resolved Hide resolved
src/battle/battle_controller_player.c Outdated Show resolved Hide resolved
src/battle/battle_controller_player.c Outdated Show resolved Hide resolved
common.mk Outdated Show resolved Hide resolved
src/battle/battle_controller_player.c Show resolved Hide resolved
src/battle/battle_controller_player.c Show resolved Hide resolved
@red031000 red031000 merged commit decd3cd into pret:master Jul 18, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants