Literally two functions #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes I know that's the mtg term I dont remember what pokemon calls it
red031000
requested changes
Jun 28, 2023
| case 1: | ||
| case 2: | ||
| case 3: | ||
| script = 271; |
There was a problem hiding this comment.
should these be consts? unsure if we have a naix for it already or not
There was a problem hiding this comment.
I tried to look for one but couldn't find it. Lhea seems to know what the consts are but I'm unsure if pret has ported those yet
| } else { | ||
| ctx->statChangeParam = 0xF; | ||
| } | ||
| ctx->statChangeType = 3; |
There was a problem hiding this comment.
same as above for these types
There was a problem hiding this comment.
I think the types are like "Special attack up" but not sure
| switch (power) { | ||
| case 1: | ||
| switch (ctx->unk_334.moveData[moveNo].effect) { | ||
| case 38: //OHKO? |
There was a problem hiding this comment.
I'm only sure about the OHKO one, gonna wait till I can get more info about move effects before documenting these
red031000
approved these changes
Jun 28, 2023
github-actions bot
pushed a commit
to red031000/pokeheartgold
that referenced
this pull request
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was hell