Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dungeon/Adventure Serialization #255

Merged
merged 17 commits into from
Nov 16, 2024

Conversation

Kermalis
Copy link
Contributor

@Kermalis Kermalis commented Nov 9, 2024

Claiming:

  • code_80450F8.s
  • code_8080CF0.s

@Kermalis Kermalis marked this pull request as ready for review November 15, 2024 21:13
@Kermalis
Copy link
Contributor Author

Done. The changes to common_strings.c are mostly to prepare for EU/JP languages. Same with personality_test1.

The other stuff is quicksave dungeon serialization.
There is the regular saving which uses bit reads/writes rather than these byte read/writes. For example:

WriteDungeonLocation refers to quicksave where it serializes per-byte.
WriteDungeonLocationBits refers to regular save where it serializes bits.

I didn't rename all the Bits variants because it's a lot and I didn't want to touch that code yet. The quicksave stuff is the stuff I dealt with

@AnonymousRandomPerson AnonymousRandomPerson merged commit a916297 into pret:master Nov 16, 2024
1 check passed
@Kermalis Kermalis deleted the serialization branch November 16, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants