Aug sept 2024 #211
Merged
Aug sept 2024 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethBarberee
force-pushed
the
aug_sept_2024
branch
2 times, most recently
from
b68f22e
to
ce53537
Compare
SethBarberee
force-pushed
the
aug_sept_2024
branch
from
aa6ea42
to
9d99557
Compare
|
Ready for review |
mateon1
reviewed
Oct 1, 2024
| targetInfo = target->info; | ||
| iVar8 = -1; | ||
| size = GetBodySize(targetInfo->apparentID); | ||
| if ((1 < ((u16)(gDungeon->bossBattleIndex - 4))) && (gDungeon->bossBattleIndex != 9) && (gDungeon->bossBattleIndex != 0xf)) { |
There was a problem hiding this comment.
This comparison has broken me. I no longer know what kind of horrendous comparison macros they could have used.
AnonymousRandomPerson
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting better about doing this more in the open so people know what I'm working on..