Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutscene macro calls #205

Merged
merged 16 commits into from
Jul 29, 2024
Merged

Cutscene macro calls #205

merged 16 commits into from
Jul 29, 2024

Conversation

LuisBoto
Copy link
Contributor

Added several project-wide macro calls, mainly on cutscene files

Copy link
Collaborator

@SethBarberee SethBarberee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cutscene file changes are fine, mainly questions on changes to files that aren't cutscenes. Not sure if there are scripting commands outside of cutscene files

data/dungeon/itempat.inc Outdated Show resolved Hide resolved
data/dungeon/etcfont.inc Outdated Show resolved Hide resolved
data/system_sbin.s Outdated Show resolved Hide resolved
data/data_8115F5C.s Outdated Show resolved Hide resolved
@LuisBoto
Copy link
Contributor Author

Cutscene file changes are fine, mainly questions on changes to files that aren't cutscenes. Not sure if there are scripting commands outside of cutscene files

You're right - sorry it does look obvious in hindsight 😅 Still getting familiar with the project, so I'll double check the replaces don't bleed into unrelated files next time. For now I've reverted those out!

@SethBarberee SethBarberee merged commit 3c7ea2b into pret:master Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants