Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kermalis sprite #151

Merged
merged 27 commits into from
Aug 28, 2023
Merged

Kermalis sprite #151

merged 27 commits into from
Aug 28, 2023

Conversation

Kermalis
Copy link
Contributor

@Kermalis Kermalis commented Aug 26, 2023 •
edited
Loading

image

@Kermalis
Match ResetSprites
7f4732f
@Kermalis
Match sub_8004E8C
b162b80
@Kermalis
Skipped 2 got 1 lol [sub_8005180]
520bcb3
@Kermalis
Forgor the declaration
c16193e
@Kermalis
Match CopySpritesToOam AND DISCOVER
c61c7df
@Kermalis
Match SetSavingIconCoords and BlinkSavingIcon
02b6c6b
@Kermalis
Match sub_80A62F0 and GroundSprite_Reset
7bcc6e0
@Kermalis
Fakematch sub_80052BC, Match sub_8005304
088162e
@Kermalis
Match sub_800533C
932d094
@Kermalis
Match sub_80A6460
cf4f529
@Kermalis
Match sub_80A64A4
254f034
@Kermalis
Match sub_80A658C through sub_80A65E0
d719c71
@Kermalis
Match sub_80053AC and make structs AF
79b3ea4
@Kermalis
Match sub_80053D0
ad5ec24
@Kermalis
Match sub_800543C and sub_800545C
710638a
@Kermalis
99.95% matching for sub_80054BC
6a633ba
@Kermalis
99.09% matching for sub_807CB3C
0225356
@Kermalis
Rename and doc SpriteOAM with defines
1d49c48
@Kermalis
Fakematch AddMenuCursorSprite_ too
06aeba8
@Kermalis
Fakematch sub_801332C and sub_8013470
afbe730
@Kermalis
Merge menu_input files
0a19222
@Kermalis
Clean menu_input
01d6fe2
SethBarberee
SethBarberee reviewed Aug 27, 2023
View reviewed changes
include/dungeon_global_data.h Outdated Show resolved Hide resolved
include/sprite.h Outdated Show resolved Hide resolved
include/sprite.h Outdated Show resolved Hide resolved
AnonymousRandomPerson
AnonymousRandomPerson approved these changes Aug 27, 2023
View reviewed changes
include/code_805D8C8.h Outdated Show resolved Hide resolved
include/sprite_oam.h Outdated Show resolved Hide resolved
src/menu_input.c Show resolved Hide resolved
@SethBarberee SethBarberee merged commit a6754cb into pret:master Aug 28, 2023
1 check passed
@Kermalis Kermalis deleted the kermalis-sprite branch August 28, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethBarberee SethBarberee SethBarberee approved these changes

@AnonymousRandomPerson AnonymousRandomPerson AnonymousRandomPerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kermalis @AnonymousRandomPerson @SethBarberee