Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this Presto pull request, we are addressing the issue where a
SELECT count(*)
query returns an emptycolumnHandles
list, leading to anArrayIndexOutOfBoundsException
when the functioncolumnHandles.get(0).getColumnType()
is called. To handle this, we are bypassing the conversion frommetricHeader
to aBlock
type (performed by thegetBlockFromMap
function at line 293 inPrometheusRecordCursor.java
). We are modifying the constructor of PrometheusStandardizedRow to accept a Map type rather than a Block. The conversion to BlockFromMap is now deferred to the getFieldValue function, where getLabels() is used.Honoring the Trino PR: trinodb/trino#12510
Motivation and Context
#23702
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: