Decimal support in TPCH

[sopel39]

Hi Guys,

As you know we have been working on decimal type for some time. We have implemented decimal using both long primitive (for short decimals) and Slice (for long decimals). We would like to benchmark decimal type using presto benchmarking mechanism. In order to do so it would be best to use decimal types in TPCH connector. We propose to introduce additional schemas in TPCH connector. We would have three schemas families: one using short decimals (precision <= 17), one using long decimals (precision > 17) and one using double types for numeric TPCH columns. Such approach would enable us to test decimal performance using in memory TPCH connector and in hive connector. It would also enable us to check compatibility with TPCH test suite, since all required types would be supported.

CC: @martint @losipiuk @cberner

[kokosing]

Is this still valid?

[sopel39]

It is

[kokosing]

Maybe it does not look that way, but the issue is about using DECIMAL in TPCH schema. As it is stated in: http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-h_v2.17.1.pdf, TPCH does not use DOUBLE at all but only DECIMAL. By DECIMAL they mean:

Decimal means that the column must be able to represent values in the range -9,999,999,999.99 to
+9,999,999,999.99 in increments of 0.01; the values can be either represented exactly or interpreted to be in this range;

In Presto that would be DECIMAL(12,2).

[kokosing]

@atris Would you take a look?

[atris]

Ack, will do

[atris]

Please see #11166

[stale]

This issue has been automatically marked as stale because it has not had any activity in the last 2 years. If you feel that this issue is important, just comment and the stale tag will be removed; otherwise it will be closed in 7 days. This is an attempt to ensure that our open issues remain valuable and relevant so that we can keep track of what needs to be done and prioritize the right things.