Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter lang map #443

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: filter lang map #443

merged 1 commit into from
Apr 16, 2024

Conversation

arzola
Copy link
Contributor

@arzola arzola commented Apr 15, 2024

Problem

  • Transifex translations are not working as expected, we introduced a change chore: add transifex config, bump version #430 to try to setup automated github sync with transifex but we are dealing with some issues regarding duplicate translation resources and missing translations.

Translation files filenames

** Before **

languages/es_ES.mo

Now

languages/pressbooks-aldine-es_ES.mo

Solution

  • Revert the translation prefix change because the old translations on this plugin are not using a prefix like pressbooks does, you can look at previous commits files doesn't contains a prefix 7e6ef6b

** After this change **

languages/es_ES.mo

Copy link
Contributor

@fdalcin fdalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdalcin fdalcin merged commit c904ab4 into dev Apr 16, 2024
5 of 6 checks passed
@fdalcin fdalcin deleted the fix/transifex-filter branch April 16, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants