Integration of CTransformers for benchmarks. #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 27, 2023 10:05
For, now only llama is supported, since it has all the three types of device support, and also it is a standard model.
nsosio
reviewed
Nov 29, 2023
There was a problem hiding this comment.
@Anindyadeep I left some comments :) furthermore, you need to update also the README.md.template with the values for ctranslate on cpu, metal (M2 Pro) and cuda on A100
bench_ctransformers/requirements.txt
Outdated
There was a problem hiding this comment.
Pin at least the major versions
Co-authored-by: Nicola Sosio <[email protected]>
Co-authored-by: Nicola Sosio <[email protected]>
merge from main.
nsosio
reviewed
Dec 1, 2023
merge from main.
- integrated setup.sh file installations. - removed un-necessary package installation inside bench.sh
nsosio
reviewed
Dec 2, 2023
bench_ctransformers/setup.sh
Outdated
| source "$VENV_DIR/bin/activate" | ||
| fi | ||
|
|
||
| install_device_specific_ctransformers "$DEVICE" |
There was a problem hiding this comment.
can't we move this after installing the requirements (line 79) to avoid reinstalling it every time? and remove the activation of the environment?
Co-authored-by: Nicola Sosio <[email protected]>
- reverted back the conditional statement. - placed install_ctransformers_cuda() function after requirements installation.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates CTransformers to allow user to benchmark models used using CTransformers.
Addresses Issue #22