-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Refactoring #68
Merged
Merged
Code Refactoring #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filopedraz
approved these changes
Nov 22, 2023
Include the Usage you provided in this PR in the README as well :) |
@filopedraz it has already been updated, in the end the entry point has only slightly changed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes #66 by introducing a reorganisation of the benchmarking structure, removing code-wise distinctions for different types of benchmarks (python_bench, rust_bench). The new structure uses one folder for each benchmark, denoted as
bench_{bench_name}
, and mandates the inclusion of abench.sh
bash script in each folder. This script is responsible for handling all necessary setup, environment configuration, and running the benchmark.Changes Made
Removed Code-wise Distinctions:
New Benchmark Folder Structure:
bench_{bench_name}
for each benchmark.bench.sh
script to handle setup, environment configuration, and benchmark execution.Benchmark Script Parameters:
bench.sh
script to support the following parameters:prompt
max_tokens
repetitions
log_file
device
models_dir
General Benchmark Script:
bench.sh
, that downloads necessary files and iterates through all benchmark folders.Usage
To run a specific benchmark, navigate to the corresponding benchmark folder (e.g.,
bench_{bench_name}
) and execute thebench.sh
script with the required parameters.Example: